Add type attribute to Invite #9682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rapptz
added
the
pending
|
The reason why I believe this wasn't documented is because the various types of invites were all experiments that didn't pan out. Friend invites died, and I don't think group invites are a thing anymore. |
|
Alright. Let's wait though what the ddevs say to it, unless you already know more than I do about whether something like this will be documented in the future. |
|
The related PR on Discord's side has been merged. |
Rapptz
removed
the
pending
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the
typeattribute toInvite.As mentioned in the related PR this change got rejected multiple times. But I don't see why. Is there a specific reason it shouldn't be implemented in the library, that I don't know?
Related PR: discord/discord-api-docs#6568
Checklist