Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for widget image #9306

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Puncher1
Copy link
Contributor

Summary

This PR adds a new method widget_image_url to Guild, which returns an URL to the widget image.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

discord/guild.py Outdated Show resolved Hide resolved
@Puncher1 Puncher1 requested a review from Gobot1234 March 18, 2023 11:50
Copy link
Owner

@Rapptz Rapptz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still unsure what the proper name for this is, since it's inconsistent with other methods that are similar, i.e. Asset but we talked about this in the discord server.

discord/guild.py Outdated Show resolved Hide resolved
@Puncher1
Copy link
Contributor Author

Puncher1 commented Mar 29, 2023

Yes. I couldn't find a good name for it. I first thought about widget_image_link but idk if this is the way to go.

@Puncher1
Copy link
Contributor Author

How about turning this into an helper function in utils.py like oauth_url?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants