Feather 32u4 RFM support #297
Conversation
|
Now that I think about it maybe "lora" is a better identifier than "rfm". I only chose "rfm" because that's whats in the product name |
There was a problem hiding this comment.
Hey, thanks a lot for the PR and sorry for only getting to it now. The changes look mostly good but of course I don't have hardware to test them. I've left a few comments below.
Re. ravedude integration: I'd handle this like the Arduino Leonardo. You can just copy what we did for that board and it should be fine. It's okay when no serial console is available, ravedude can also only do the flashing without opening a console session. That said, I'm fine with merging this without ravedude integration for the time being. This is something we can get back to later.
| /// `D8` | ||
| /// For radio module | ||
| /// | ||
| /// * PCINT4 | ||
| /// * CS | ||
| /// * ADC11 | ||
| pub d8: atmega_hal::port::PB4 = pb4, | ||
|
|
||
| /// `D7` | ||
| /// For radio module | ||
| /// | ||
| /// * INT6 | ||
| /// * IRQ | ||
| /// * AIN0 | ||
| pub d7: atmega_hal::port::PE6 = pe6, | ||
|
|
||
| /// `D4` | ||
| /// For radio module | ||
| /// | ||
| /// * ICP1 | ||
| /// * RST | ||
| /// * ADC8 | ||
| pub d4: atmega_hal::port::PD4 = pd4, |
There was a problem hiding this comment.
You mention For radio module in these pins' documentation. Maybe we can give the pins more descriptive names about their function on the board?
Co-authored-by: Rahix <rahix@rahix.de>
Co-authored-by: Rahix <rahix@rahix.de>
Based off of #224. It should work with the RFM69 and RFM9x variants. I successfully got blinky to run on my RFM69 variant. I can't figure out how to get serial logging to work so someone else might want to give that a shot. Next I want to add ravedude support but since that requires serial logging support I might just work on adding more examples first.