Update Serial #249
Open
Update Serial #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is suggested in the atmega328p manual and theoretically applies to other AVR boards. It is for future compatibility.
These currently don't work on AVR and won't be able to work on AVR until rust updates AVR asm. As a work around, manually implement them.
This is based off of how the Arduino C++ library does serial. It uses interrupts and buffers to avoid missing data.
rursprung
added a commit
to rursprung/avr-hal
that referenced
this pull request
Dec 28, 2023
with `embedded-hal` v1 the USART traits have been removed in favour of the new `embedded-io` crate. this adds a (very basic) implementation for `Read` and `Write`. other traits (such as the `*Ready` or `BufRead` traits) have not (yet) been implemented and some (like `Seek`) probably can't be implemented for this HAL. a better implementation might use a buffer in the background to receive more than one byte at once. see also Rahix#249 for a related PR. this is part of Rahix#468
rursprung
added a commit
to rursprung/avr-hal
that referenced
this pull request
Dec 28, 2023
with `embedded-hal` v1 the USART traits have been removed in favour of the new `embedded-io` crate. this adds a (very basic) implementation for `Read` and `Write`. other traits (such as the `*Ready` or `BufRead` traits) have not (yet) been implemented and some (like `Seek`) probably can't be implemented for this HAL. a better implementation might use a buffer in the background to receive more than one byte at once. see also Rahix#249 for a related PR. this is part of Rahix#468
rursprung
added a commit
to rursprung/avr-hal
that referenced
this pull request
Jan 17, 2024
with `embedded-hal` v1 the USART traits have been removed in favour of the new `embedded-io` crate. this adds a (very basic) implementation for `Read` and `Write`. other traits (such as the `*Ready` or `BufRead` traits) have not (yet) been implemented and some (like `Seek`) probably can't be implemented for this HAL. a better implementation might use a buffer in the background to receive more than one byte at once. see also Rahix#249 for a related PR. this is part of Rahix#468
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the DataRegisterEmpty serial event, adds the TxComplete serial event, and creates a more robust serial example that is similar to how Arduino C++ does serial.
closes #220
closes #248