support reality #1710
support reality #1710
Conversation
test on mac m1,it work
| @@ -101,7 +101,8 @@ void MainWindow::MWSetSystemProxy() | |||
| LOG("ProxyAddress: " + proxyAddress); | |||
| LOG("HTTP Port: " + QSTRN(httpPort)); | |||
| LOG("SOCKS Port: " + QSTRN(socksPort)); | |||
| SetSystemProxy(proxyAddress, httpPort, socksPort); | |||
| // If you need to automatically set up the system proxy function,you can enable the handle commented out below | |||
There was a problem hiding this comment.
this is not related to REALITY, please consider removing it from the PR
| { | ||
| QString output = QString(process.readAllStandardOutput()); | ||
| QString output = QString(process.readAllStandardOutput()); |
| @@ -149,7 +149,6 @@ namespace Qv2ray::core::config | |||
| { | |||
| // Use the config path found by the checks above | |||
| SetConfigDirPath(configPath); | |||
| LOG("Using ", QV2RAY_CONFIG_DIR, " as the config path."); | |||
There was a problem hiding this comment.
is there a good reason for removing this line?
| @@ -393,3 +410,25 @@ void StreamSettingsWidget::on_httpHeadersEditBtn_clicked() | |||
| json["headers"] = rJson; | |||
| stream.httpSettings.headers = HttpObject::fromJson(json).headers; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
it seems that you didn't format your codebase with clang-format, please consider doing so.
| void StreamSettingsWidget::on_spiderX_textEdited(const QString &arg1) | ||
| { | ||
| stream.realitySettings.spiderX = arg1; | ||
| } |
There was a problem hiding this comment.
also, add a newline before EOF
| <message> | ||
| <source>Short id</source> | ||
| <translation>短ID(不一定支持)</translation> | ||
| </message> | ||
| <message> | ||
| <source>SpiderX</source> | ||
| <translation>初始路径(不一定支持)</translation> | ||
| </message> |
There was a problem hiding this comment.
translations are done on https://crowdin.com/project/qv2ray
|
The overall code quality can be improved and several unnecessary changes should be avoided. |
|
I'm not a professional C++ developer, but I'm learning it, and thanks for your rigor, I've benefited a lot. Give me time and I will fix the problems you mentioned. |
No description provided.