Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade IQFeed.CSharpApiClient and Project Restructuring #9

Conversation

Romazes
Copy link
Contributor

@Romazes Romazes commented Feb 1, 2024

Description

  • Downgraded IQFeed.CSharpApiClient version from "2.7.0" to "2.5.1" due to a bug in version 2.7.0, causing a method not found error.
  • Removed the IQFeed.Downloader project and consolidated it into the main IQFeed project for better code organization.
  • Commented out Log.DebuggingEnabled = true; to prevent debug logs from being displayed in the action.

Related Issue

N/A

Motivation and Context

The motivation behind these changes is to resolve the method not found bug encountered in version 2.7.0 of IQFeed.CSharpApiClient. Additionally, consolidating the IQFeed.Downloader project into the main project aims to improve code maintainability and organization.

Requires Documentation Change

N/A

How Has This Been Tested?

The changes have been tested by creating a package of the IQFeed project, deploying it to a specific location, and running tests with Docker. This process ensures that the downgraded version of IQFeed.CSharpApiClient (2.5.1) functions correctly and that the project restructuring does not introduce any new issues.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

@Romazes Romazes force-pushed the feature-download-proj-combine-with-main-downgrade-package branch from 3b35136 to dc9e20c Compare February 1, 2024 18:20
Copy link
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@Martin-Molinero Martin-Molinero merged commit 05a657c into QuantConnect:master Feb 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants