Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return null from GetHistory and Downloader #8

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

Romazes
Copy link
Collaborator

@Romazes Romazes commented Feb 26, 2024

Description

Related Issue

N/A

Motivation and Context

Maintain a uniform code format like in others repos.
Support several Data Sources.

Requires Documentation Change

N/A

How Has This Been Tested?

Fixed old tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

@Romazes Romazes changed the title Return **null** from GetHistory and Downloader Return null from GetHistory and Downloader Feb 26, 2024
Copy link
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@Martin-Molinero Martin-Molinero merged commit 1f11e07 into QuantConnect:master Feb 27, 2024
1 check failed
@Romazes Romazes deleted the feature-null-history branch March 14, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants