Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialization via Job Packet and Rename DataQueueHandler to DataProvider #7

Merged
merged 7 commits into from
Feb 21, 2024

Conversation

Romazes
Copy link
Collaborator

@Romazes Romazes commented Feb 20, 2024

Description

  1. Feature Enhancement: Initialization via Job Packet
  • Implements initialization functionality through Job packets, enhancing the efficiency and flexibility of the system.
    Provides a streamlined method for initializing processes, improving overall performance and maintainability.
  1. Code Refactoring: Renaming DataQueueHandler to DataProvider
  • Renames the DataQueueHandler class to DataProvider for improved clarity and consistency in naming conventions.
    Enhances code readability and understandability, aligning with best practices for naming conventions.
  1. Use Globals for credentials access for subscription validation.

Related Issue

N/A

Motivation and Context

  1. Feature Enhancement: Initialization via Job Packet
  • As the system evolves, there is a growing need for a more robust and flexible initialization process. Implementing initialization through Job packets provides an efficient and adaptable solution, enhancing overall system efficiency and maintainability.
  1. Code Refactoring: Renaming DataQueueHandler to DataProvider
  • Clear and consistent naming conventions are crucial for improving code maintainability. Renaming DataQueueHandler to DataProvider aligns with best practices, improving code clarity and making it easier for developers to understand and work with the codebase.

Requires Documentation Change

N/A

How Has This Been Tested?

To ensure the robustness and correctness of the Job initialization process, the PR have been implemented specific test cases.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

Copy link
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@Martin-Molinero Martin-Molinero merged commit 0d365ad into QuantConnect:master Feb 21, 2024
1 of 2 checks passed
@Romazes Romazes deleted the feature-cloud-support branch March 14, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants