feat: add stop spamming flags

feat: null sign refactor: remove extra else block
QuantConnect · Feb 23, 2024 · 4c2f7fa · 4c2f7fa
1 parent ff7e0f4
commit 4c2f7fa
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 9 deletions.
diff --git a/QuantConnect.CoinAPI/CoinApiDataHistoryProvider.cs b/QuantConnect.CoinAPI/CoinApiDataHistoryProvider.cs
@@ -37,12 +37,23 @@ public partial class CoinApiDataProvider
         /// </summary>
         private bool _invalidHistoryDataTypeWarningFired;
 
+        /// <summary>
+        /// Indicates whether the warning for invalid <see cref="SecurityType"/> has been fired.
+        /// </summary>
+        private bool _invalidSecurityTypeWarningFired;
+
+        /// <summary>
+        /// Indicates whether the warning for invalid <see cref="Resolution"/> has been fired.
+        /// </summary>
+        private bool _invalidResolutionTypeWarningFired;
+
+
         public override void Initialize(HistoryProviderInitializeParameters parameters)
         {
             // NOP
         }
 
-        public override IEnumerable<Slice> GetHistory(IEnumerable<HistoryRequest> requests, DateTimeZone sliceTimeZone)
+        public override IEnumerable<Slice>? GetHistory(IEnumerable<HistoryRequest> requests, DateTimeZone sliceTimeZone)
         {
             var subscriptions = new List<Subscription>();
             foreach (var request in requests)
@@ -65,17 +76,25 @@ public override IEnumerable<Slice> GetHistory(IEnumerable<HistoryRequest> reques
             return CreateSliceEnumerableFromSubscriptions(subscriptions, sliceTimeZone);
         }
 
-        public IEnumerable<BaseData> GetHistory(HistoryRequest historyRequest)
+        public IEnumerable<BaseData>? GetHistory(HistoryRequest historyRequest)
         {
             if (!CanSubscribe(historyRequest.Symbol))
             {
-                Log.Error($"CoinApiDataProvider.GetHistory(): Invalid security type {historyRequest.Symbol.SecurityType}");
+                if (!_invalidSecurityTypeWarningFired)
+                {
+                    Log.Error($"CoinApiDataProvider.GetHistory(): Invalid security type {historyRequest.Symbol.SecurityType}");
+                    _invalidSecurityTypeWarningFired = true;
+                }
                 return null;
             }
 
             if (historyRequest.Resolution == Resolution.Tick)
             {
-                Log.Error($"CoinApiDataProvider.GetHistory(): No historical ticks, only OHLCV timeseries");
+                if (!_invalidResolutionTypeWarningFired)
+                {
+                    Log.Error($"CoinApiDataProvider.GetHistory(): No historical ticks, only OHLCV timeseries");
+                    _invalidResolutionTypeWarningFired = true;
+                }
                 return null;
             }
 

diff --git a/QuantConnect.CoinAPI/CoinApiDataProvider.cs b/QuantConnect.CoinAPI/CoinApiDataProvider.cs
@@ -149,7 +149,7 @@ public void SetJob(LiveNodePacket job)
         /// <exception cref="ArgumentException"></exception>
         private void Initialize(string apiKey, string product)
         {
-            // ValidateSubscription();
+            ValidateSubscription();
 
             _apiKey = apiKey;
 
@@ -365,10 +365,8 @@ private void SendHelloMessage(IEnumerable<string> subscribeFilter)
             {
                 throw new Exception("Not connected...");
             }
-            else
-            {
-                IsConnected = true;
-            }
+
+            IsConnected = true;
 
             _nextHelloMessageUtcTime = DateTime.UtcNow.Add(_minimumTimeBetweenHelloMessages);
         }