Skip to content

Commit

Permalink
Enhancing AlphaVantage Data Source Integration (#2)
Browse files Browse the repository at this point in the history
* remove: template files
feat: create solution file

* feat: init projects

* feat: paste old version files

* remove: not used download program file

* feat: create empty ctor AlphaVantageDataDownloader
feat: handle several exception
fix: req param
feat: create new live UTests
rename: mock file

* fix: Get(minute\hour tradebar) API request
feat: new test cases

* feat: convert utc to exchangeTime history dateTime
remove: limit 2 year for minute\hour request

* feat: ValidateSubscription()

* refactor: skip ApiKey in log.Trace
fix: mock unit tests
feat: warning on 25req/day for live tests

* feat: add github templates of Issue and PR

* fix: GH workflow ci\cd file
feat: comment flag to not show extra log in Action pipeline

* fix: product id in ValidateSubscription

* feat: integrate different configurable Price Plan

* Create LICENSE

* Update README.md
  • Loading branch information
Romazes committed Feb 6, 2024
1 parent 523fbec commit 6a71ff2
Show file tree
Hide file tree
Showing 38 changed files with 1,650 additions and 1,388 deletions.
27 changes: 27 additions & 0 deletions .github/issue_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
<!--- This template provides sections for bugs and features. Please delete any irrelevant sections before submitting -->

#### Expected Behavior
<!--- Required. Describe the behavior you expect to see for your case. -->

#### Actual Behavior
<!--- Required. Describe the actual behavior for your case. -->

#### Potential Solution
<!--- Optional. Describe any potential solutions and/or thoughts as to what may be causing the difference between expected and actual behavior. -->

#### Reproducing the Problem
<!--- Required for Bugs. Describe how to reproduce the problem. This can be via a failing unit test or a simplified algorithm that reliably demonstrates this issue. -->

#### System Information
<!--- Required for Bugs. Include any system specific information, such as OS. -->

#### Checklist
<!--- Confirm that you've provided all the required information. -->
<!--- Required fields --->
- [ ] I have completely filled out this template
- [ ] I have confirmed that this issue exists on the current `master` branch
- [ ] I have confirmed that this is not a duplicate issue by searching [issues](https://github.com/QuantConnect/Lean/issues)
<!--- Required for Bugs, feature request can delete the line below. -->
- [ ] I have provided detailed steps to reproduce the issue

<!--- Template inspired by https://github.com/stevemao/github-issue-templates -->
42 changes: 42 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@

<!--- Provide a general summary of your changes in the Title above -->

#### Description
<!--- Describe your changes in detail -->

#### Related Issue
<!--- This project only accepts pull requests related to open issues -->
<!--- If suggesting a new feature or change, please discuss it in an issue first -->
<!--- If fixing a bug, there should be an issue describing it with steps to reproduce -->
<!--- Please link to the issue here: -->

#### Motivation and Context
<!--- Why is this change required? What problem does it solve? -->

#### Requires Documentation Change
<!--- Please indicate if these changes will require updates to documentation, and if so, specify what changes are required -->

#### How Has This Been Tested?
<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran to -->
<!--- see how your change affects other areas of the code, etc. -->

#### Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Refactor (non-breaking change which improves implementation)
- [ ] Performance (non-breaking change which improves performance. Please add associated performance test and results)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] Non-functional change (xml comments/documentation/etc)

#### Checklist:
<!--- The following is a checklist of items that MUST be completed before a PR is accepted -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [ ] My code follows the code style of this project.
- [ ] I have read the **CONTRIBUTING** [document](https://github.com/QuantConnect/Lean/blob/master/CONTRIBUTING.md).
- [ ] I have added tests to cover my changes. <!--- If not applicable, please explain why -->
- [ ] All new and existing tests passed.
- [ ] My branch follows the naming convention `bug-<issue#>-<description>` or `feature-<issue#>-<description>`

<!--- Template inspired by https://www.talater.com/open-source-templates/#/page/99 -->
32 changes: 19 additions & 13 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,18 +9,18 @@ on:
jobs:
build:
runs-on: ubuntu-20.04

env:
QC_JOB_USER_ID: ${{ secrets.QC_JOB_USER_ID }}
QC_API_ACCESS_TOKEN: ${{ secrets.QC_API_ACCESS_TOKEN }}
QC_JOB_ORGANIZATION_ID: ${{ secrets.QC_JOB_ORGANIZATION_ID }}
QC_ALPHA_VANTAGE_API_KEY: ${{ secrets.QC_ALPHA_VANTAGE_API_KEY }}
steps:
- uses: actions/checkout@v2
- name: Checkout
uses: actions/checkout@v2

- name: Free space
run: df -h && rm -rf /opt/hostedtoolcache* && df -h

- name: Pull Foundation Image
uses: addnab/docker-run-action@v3
with:
image: quantconnect/lean:foundation

- name: Checkout Lean Same Branch
id: lean-same-branch
uses: actions/checkout@v2
Expand All @@ -40,11 +40,17 @@ jobs:
- name: Move Lean
run: mv Lean ../Lean

- name: BuildDataSource
run: dotnet build ./QuantConnect.DataSource.csproj /p:Configuration=Release /v:quiet /p:WarningLevel=1
- name: Pull Foundation Image
uses: addnab/docker-run-action@v3
with:
image: quantconnect/lean:foundation
options: -v /home/runner/work:/__w --workdir /__w/Lean.DataSource.AlphaVantage/Lean.DataSource.AlphaVantage -e QC_JOB_USER_ID=${{ secrets.QC_JOB_USER_ID }} -e QC_API_ACCESS_TOKEN=${{ secrets.QC_API_ACCESS_TOKEN }} -e QC_JOB_ORGANIZATION_ID=${{ secrets.QC_JOB_ORGANIZATION_ID }} -e QC_ALPHA_VANTAGE_API_KEY=${{ secrets.QC_ALPHA_VANTAGE_API_KEY }}

- name: Build QuantConnect.AlphaVantage
run: dotnet build ./QuantConnect.AlphaVantage/QuantConnect.AlphaVantage.csproj /p:Configuration=Release /v:quiet /p:WarningLevel=1

- name: BuildTests
run: dotnet build ./tests/Tests.csproj /p:Configuration=Release /v:quiet /p:WarningLevel=1
- name: Build QuantConnect.AlphaVantage.Tests
run: dotnet build ./QuantConnect.AlphaVantage.Tests/QuantConnect.AlphaVantage.Tests.csproj /p:Configuration=Release /v:quiet /p:WarningLevel=1

- name: Run Tests
run: dotnet test ./tests/bin/Release/net6.0/Tests.dll
- name: Run QuantConnect.AlphaVantage.Tests
run: dotnet test ./QuantConnect.AlphaVantage.Tests/bin/Release/QuantConnect.AlphaVantage.Tests.dll
12 changes: 0 additions & 12 deletions DataProcessing/CLRImports.py

This file was deleted.

30 changes: 0 additions & 30 deletions DataProcessing/DataProcessing.csproj

This file was deleted.

0 comments on commit 6a71ff2

Please sign in to comment.