-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
substitute c++14 for c++17 with more environment variables #19
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
But I think that only resetting DEBUG_CXXFLAGS makes sense.
if [ -v CXXFLAGS_CONDA_NVCC_BACKUP ] ; then | ||
export CXXFLAGS_CONDA_NVCC_BACKUP="`echo $CXXFLAGS_CONDA_NVCC_BACKUP | sed 's/-std=c++17/-std=c++14/'`" | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CXXFLAGS_CONDA_NVCC_BACKUP should not be changed, it is needed for deactivating the environment.
export CXXFLAGS_USED="`echo $CXXFLAGS_USED | sed 's/-std=c++17/-std=c++14/'`" | ||
fi | ||
if [ -v DEBUG_CXXFLAGS ] ; then | ||
export DEBUG_CXXFLAGS="`echo $DEBUG_CXXFLAGS | sed 's/-std=c++17/-std=c++14/'`" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's ok but has a typo in sed command: it misses the tailing g
if [ -v CXXFLAGS_CONDA_NVCC_BACKUP ] ; then | ||
export CXXFLAGS_CONDA_NVCC_BACKUP="`echo $CXXFLAGS_CONDA_NVCC_BACKUP | sed 's/-std=c++17/-std=c++14/'`" | ||
fi | ||
if [ -v CXXFLAGS_USED ] ; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what defines CXXFLAGS_USED? Is it used within pytorch build system?
I can't really answer any of the questions about these environment variables, I do not know where they came from. Feel free to close this, as it was more of a proof-of-concept of what worked for me. |
Maybe this is overkill. At least one of these broke my environment. I don't know which one, but is sure was frustrating to dig around and find this.