Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use FluentAssertions #383

Merged
merged 6 commits into from
Mar 28, 2024
Merged

Use FluentAssertions #383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a3ae76b
Update decimal rounding.
Corniel Mar 28, 2024
fa68a63
Enforce FA alternative.
Corniel Mar 28, 2024
8b2ba9e
Use FA.
Corniel Mar 28, 2024
c797a7c
Update remaining Asserts (except legacy tests).
Corniel Mar 28, 2024
915f053
Boy-scout.
Corniel Mar 28, 2024
514fd3d
Prevent package validation issues for now.
Corniel Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions .editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,14 @@ dotnet_diagnostic.CA2254.severity = warning # Template should be a static expres
dotnet_diagnostic.CS8763.severity = warning # A method marked [DoesNotReturn] should not return.
dotnet_diagnostic.CS8770.severity = warning # Method lacks [DoesNotReturn] annotation to match implemented or overridden member.

dotnet_diagnostic.FAA0004.severity = error # Replace NUnit assertion with Fluent Assertions equivalent

dotnet_diagnostic.NUnit1001.severity = none # The individual arguments provided by a TestCaseAttribute must match the type of the corresponding parameter of the method
dotnet_diagnostic.NUnit2005.severity = suggestion # Consider using Assert.That(actual, Is.EqualTo(expected)) instead of Assert.AreEqual(expected, actual)
dotnet_diagnostic.NUnit2021.severity = warning # Incompatible types for EqualTo constraint



dotnet_diagnostic.QW0001.severity = none # Use a testable Time Provider
dotnet_diagnostic.QW0010.severity = none # Use DateOnly instead of Date
dotnet_diagnostic.QW0003.severity = warning # Decorate Pure functions
Expand Down
2 changes: 2 additions & 0 deletions props/package.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@

<PropertyGroup Label="Package info">
<IsPackable>true</IsPackable>
<!-- disable for now -->
<EnablePackageValidation>false</EnablePackageValidation>
<PackageIcon>package-icon.png</PackageIcon>
<PackageIconUrl>https://github.com/Qowaiv/Qowaiv/blob/master/design/package-icon.png</PackageIconUrl>
<PackageLicenseExpression>MIT</PackageLicenseExpression>
Expand Down