Add Buffer Size Parameter to dump create #234
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the contribution. I'm going to take a look this weekend |
evoxmusic
requested changes
Nov 6, 2022
replibyte/src/tasks/full_dump.rs
Outdated
| } | ||
|
|
||
| impl<'a, S> FullDumpTask<'a, S> | ||
| where | ||
| S: Source, | ||
| { | ||
| pub fn new(source: S, datastore: Box<dyn Datastore>, options: SourceOptions<'a>) -> Self { | ||
| pub fn new(source: S, datastore: Box<dyn Datastore>, options: SourceOptions<'a>, arg_buffer_size: usize) -> Self { |
There was a problem hiding this comment.
My 2 comments:
- Include
arg_buffer_sizeintooptionsand removearg_buffer_sizeparameter - rename
options.arg_buffer_sizeinto something more explicit likedump_chunk_sizeor anything else
|
Good idea! I will do some work on the fixes. |
|
@evoxmusic, added Also have to play a little bit with the test methods 馃槂 |
|
@gugacavalieri can you check tests errors? |
|
Thanks for adding this, can you also update the README with an example of how to use this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
buffer_sizewhen dumping the database100(This was the previous value)Motivation
I was running into the same issue when dumping tables bigger than 100MB (#208). The order of the Statements were wrong and I was not able to restore the dumps. I still don't know 100% what is cause the issue but it's probably related when the compressed chunks are being read from the datastore and are being restored in the wrong order.
So, this PR aims to make the arguments more flexible and serve as a workaround for the issue above.
PS. I am still learning Rust, so please let me know if this is a good way to move parameters around 馃槃