Emit a better error for abi3 inheritance #4185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejrs
force-pushed
the
diagnostic
branch
2 times, most recently
from
7e688b5
to
5d267c7
Compare
loewenheim
approved these changes
May 14, 2024
mejrs
force-pushed
the
diagnostic
branch
7 times, most recently
from
108a57e
to
cee1c7e
Compare
davidhewitt
reviewed
May 15, 2024
mejrs
force-pushed
the
diagnostic
branch
3 times, most recently
from
ef4d978
to
5e96c6a
Compare
davidhewitt
reviewed
May 15, 2024
tests/test_compile_error.rs
Outdated
|
|
||
| #[cfg(not(target_arch = "wasm32"))] // Not possible to invoke compiler from wasm | ||
| #[test] | ||
| fn test_diagnostics() { |
There was a problem hiding this comment.
Now that we're not gating the above, do we need this separate test?
There was a problem hiding this comment.
I thought it would be useful to separate into "we don't want this to compile" and "we want a decent error message for this". I'm happy to combine them if you want.
There was a problem hiding this comment.
Usually my hope for all these tests is to have a good error message, so I think it's simpler to combine. 😁
mejrs
force-pushed
the
diagnostic
branch
2 times, most recently
from
f28b889
to
849d42b
Compare
davidhewitt
approved these changes
May 16, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
I think the |
davidhewitt
reviewed
May 17, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm excited to finally use
diagnostic::on_unimplemented:)