-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable custom cluster based thresholding for non-volumic dataset #453
base: master
Are you sure you want to change the base?
Conversation
Please have a look at #395 which wip to make it work with arbitrary queryengines and extended set of measures... Would be nice to join efforts |
Codecov Report
@@ Coverage Diff @@
## master #453 +/- ##
==========================================
- Coverage 76.66% 76.63% -0.04%
==========================================
Files 364 364
Lines 41341 41366 +25
Branches 6667 6672 +5
==========================================
+ Hits 31695 31700 +5
- Misses 7751 7770 +19
- Partials 1895 1896 +1
Continue to review full report at Codecov.
|
I didn't see that it was WIP, I will follow your pull request. Thanks! |
modified the GroupClusterThreshold to enable clustering using custom neighborhood definition (as a sparse matrix of connectivity) that can process surface based dataset for example.
from an array
tris
defining the triangles of the surface, connectivity can be obtained with:I prefer to provide neighborhood than do something surface-specific as I have dataset mixing surfaces and ROIs (HCP-style).
Runs quite fast (comparable to the volume based).
Testing needed, but wanted to have feedback on the structure.