Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WiP: NF: Utility command to make surface renderings #401

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mih
Copy link
Member

@mih mih commented Jan 11, 2016

For those of us who are mentally incompatible with SUMA ;-)

Lots of docs missing, obviously. Question is: do we want such thing in PyMVPA at all?

@yarikoptic
Copy link
Member

we need one, but not only as cmdline utility, but also as a regular python function

advantage of @nno's one though is that it doesn't require any fancy 3d libraries, and theoretically could be improved to work on surfaces loaded straight from FS

@mih
Copy link
Member Author

mih commented Jan 12, 2016

I assume you are referring to the flat surface plotter? I think these those are somewhat complementary. I rarely use flat maps and often prefer inflated (or partially inflated) surfaces, because I think they are easier to read.

Turning this whole thing into a big function is trivial.

Dependency issue is, and remains, a big bummer -- not much to argue...

@yarikoptic
Copy link
Member

yeap -- meant flat surface plotter. @nno -- any chance to get it fixed?

as for this one -- I don't mind any new functionality ;)

@nno
Copy link
Contributor

nno commented Jan 15, 2016

Thanks for the reminder @yarikoptic; I'll try to look into this in the next few days.

@nno
Copy link
Contributor

nno commented Jan 18, 2016

See #415 for improved surface plotting functionality.

@mih
Copy link
Member Author

mih commented Mar 28, 2016

@yarikoptic @nno What about this one? Merge or reject?

@yarikoptic
Copy link
Member

does it work for you? for travis? ;-)

@mih
Copy link
Member Author

mih commented Mar 28, 2016

Works for me. Does travis come with Freesurfer? Should we install it prior
each test run? ;-)
On Mar 28, 2016 15:11, "Yaroslav Halchenko" notifications@github.com
wrote:

does it work for you? for travis? ;-)


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#401 (comment)

@yarikoptic
Copy link
Member

for now we could adopt what pysurfer itself is doing:

    - wget --quiet http://faculty.washington.edu/larsoner/fsaverage_min.zip
    - mkdir subjects
    - cd subjects
    - unzip ../fsaverage_min.zip
    - cd ..
    - export SUBJECTS_DIR="${PWD}/subjects"

@mih
Copy link
Member Author

mih commented Mar 28, 2016

That gives us minimal data, but if you run this command you'll see that it executes actual Freesurfer commands. It needs a full install. Maybe it could be worked around somehow with some effort, but for the 20 lines of plain pysurfer code, I'd rather close this PR unmerged than to spend a day figuring this out. TBH. No worries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants