Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cv pass attr #384

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Cv pass attr #384

wants to merge 9 commits into from

Conversation

bpinsard
Copy link

when cross-validating with partitions that doesn't use all dataset as testing or not in the same order than dataset samples, the passed attrs raise error for size mismatch or are either incoherent.

@yarikoptic
Copy link
Member

so seems to be pointing to the general flaw in the design that in many cases pass_attr should be either explicitly forbidden OR we would need to add some special ".sa._index_uid" and ".fa._index_uid" (where uid some random unique str) upon each invocation (if pass_attr defined) to verify if res has it identical to original, and if not -- kaboom! (not just silently ignore) since it points to the user's wrong assumption about what the beast was intended to do...

@yarikoptic yarikoptic modified the milestone: 2.4.2 Nov 19, 2015
@yarikoptic yarikoptic modified the milestones: 2.4.2, Release 2.6.1 Aug 23, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-16.3%) to 64.929% when pulling 0803548 on bpinsard:cv_pass_attr into 7e9020b on PyMVPA:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants