-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cv pass attr #384
base: master
Are you sure you want to change the base?
Cv pass attr #384
Conversation
so seems to be pointing to the general flaw in the design that in many cases pass_attr should be either explicitly forbidden OR we would need to add some special ".sa._index_uid" and ".fa._index_uid" (where uid some random unique str) upon each invocation (if pass_attr defined) to verify if res has it identical to original, and if not -- kaboom! (not just silently ignore) since it points to the user's wrong assumption about what the beast was intended to do... |
when cross-validating with partitions that doesn't use all dataset as testing or not in the same order than dataset samples, the passed attrs raise error for size mismatch or are either incoherent.