Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: added mappers/statis.py #241

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

andycon
Copy link
Contributor

@andycon andycon commented Sep 14, 2014

OK. This is a minimal working addition of my statis code. There is a ipython notebook that can be/should be used to build a test for statis. Will work on that next.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.77%) when pulling f2a8343 on andycon:_statis into 50d15b8 on PyMVPA:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.77%) when pulling f2a8343 on andycon:_statis into 50d15b8 on PyMVPA:master.

@nno
Copy link
Contributor

nno commented Sep 14, 2014

Thanks for the PR.
Could you provide a unit-test? For starters it would be good to have a test that starts with a dataset as input, runs statis, and verifies that the output is as expected.
(For inspiration, consider: https://github.com/CoSMoMVPA/CoSMoMVPA/blob/master/tests/test_distatis.m)

@nno
Copy link
Contributor

nno commented Jun 30, 2015

It's been more than half a year. @andycon, would you be able to supply a unit test for this code?

@andycon
Copy link
Contributor Author

andycon commented Jul 6, 2015

Thanks for the reminder. I have been on vacation, and I have a grant app
due next monday. I will put this on my list for next week.

ac

On Tue, Jun 30, 2015 at 10:37 AM, Nikolaas N. Oosterhof <
notifications@github.com> wrote:

It's been more than half a year. @andycon https://github.com/andycon,
would you be able to supply a unit test for this code?


Reply to this email directly or view it on GitHub
#241 (comment).

Andrew C. Connolly, Ph.D.
Assistant Professor in Neurology
Geisel School of Medicine at Dartmouth
582K01 Borwell, DHMC
Lebanon, NH 03756

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants