Refactor: Search Footer and how it handles user input #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lagicrus
changed the title
|
In testing this seems to break indexer selection. Appears indexersIds are not passed in the search request resulting in searching of all
|
bakerboy448
added
Status: Waiting for OP
Adds Prowlarr#355 back in
bakerboy448
added
Area: UI
|
This additionally fixes #357 2021-07-24_13-35-57.mp4 |
* adjust search term for individual season in ipt * adjust search term for individual season in ipt Co-authored-by: chryzsh <chrisrisvik@mail.com>
* first attempt at sc definition * add dologin. seems to return html instead of json * barebones working setup * added category but errors on override * fixed and tested * guid fix * fixed bdmv and dvd releases to report in radarr accepted format * minor fixes * fixed sc * first attempt at SC categories * category fixes for movies and music * toggled back IsProduction Co-authored-by: unknown <chrisrisvik@mail.com>
Fixed: (TPB) Missing Magnet Download Link
Fixes Logs of Prowlarr#472 > 2021-08-28 05:59:47.8|Error|Xthor|An error occurred while processing indexer feed. https://api.xthor.tk?passkey=(removed)&category=12%2B125%2B104%2B13%2B15%2B14%2B98%2B17%2B16%2B101%2B32%2B110%2B123%2B109%2B34%2B30&accent=1 [v0.1.1.875] System.Exception: Triggered AntiSpam Protection, please delay your requests! at NzbDrone.Core.Indexers.Definitions.Xthor.XthorParser.CheckApiState(XthorError state) in D:\a\1\s\src\NzbDrone.Core\Indexers\Definitions\Xthor\XthorParser.cs:line 112 at NzbDrone.Core.Indexers.Definitions.Xthor.XthorParser.ParseResponse(IndexerResponse indexerResponse) in D:\a\1\s\src\NzbDrone.Core\Indexers\Definitions\Xthor\XthorParser.cs:line 32 at NzbDrone.Core.Indexers.HttpIndexerBase`1.FetchPage(IndexerRequest request, IParseIndexerResponse parser) in D:\a\1\s\src\NzbDrone.Core\Indexers\HttpIndexerBase.cs:line 321 at NzbDrone.Core.Indexers.HttpIndexerBase`1.FetchReleases(Func`2 pageableRequestChainSelector, Boolean isRecent) in D:\a\1\s\src\NzbDrone.Core\Indexers\HttpIndexerBase.cs:line 174 RequestUri: https://api.xthor.tk?passkey=(removed)&category=12%2B125%2B104%2B13%2B15%2B14%2B98%2B17%2B16%2B101%2B32%2B110%2B123%2B109%2B34%2B30&accent=1;StatusCode: OK;ContentType: application/json;ContentLength: 133;ContentSample: { "error": { "code": 8, "descr": "Protection Anti-Spam: A.P.I limitee a 1 requete toutes les 2 secondes." } };FeedUrl: https://api.xthor.tk?passkey=(removed)&category=12%2B125%2B104%2B13%2B15%2B14%2B98%2B17%2B16%2B101%2B32%2B110%2B123%2B109%2B34%2B30&accent=1
|
conflicts - needs rebase |
Ref Prowlarr#280 YGG Comment
Currently translated at 100.0% (441 of 441 strings) Translated using Weblate (Chinese (Simplified) (zh_CN)) Currently translated at 62.5% (276 of 441 strings) Translated using Weblate (Hungarian) Currently translated at 100.0% (441 of 441 strings) Co-authored-by: Csaba <csab0825@gmail.com> Co-authored-by: Havok Dan <havokdan@yahoo.com.br> Co-authored-by: Weblate <noreply@weblate.org> Co-authored-by: angelsky11 <angelsky11@gmail.com> Translate-URL: https://translate.servarr.com/projects/servarr/prowlarr/hu/ Translate-URL: https://translate.servarr.com/projects/servarr/prowlarr/pt_BR/ Translate-URL: https://translate.servarr.com/projects/servarr/prowlarr/zh_CN/ Translation: Servarr/Prowlarr Co-authored-by: Weblate <noreply@weblate.org> Co-authored-by: Csaba <csab0825@gmail.com> Co-authored-by: Havok Dan <havokdan@yahoo.com.br> Co-authored-by: angelsky11 <angelsky11@gmail.com>
Adds Prowlarr#355 back in
…ch-rerender-fixes
Should be fixed now |
I'm kinda guessing you didn't mean to merge 100+ commits. There may have been a force push or maybe you did a bad rebase but this I think may need some adjustment? You are like 110 commits to many here lol |
Ye.. I told it to rebase and here we are 😔 |
|
Did you fetch upstream develop before you rebased on it? |
|
Believe so yes? Was I not supposed to? |
you're supposed to, but you def didn't rebase off upstream develop it'd seemed regardless - conflicts & needs the rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Database Migration
NO
Description
Currently, when you use the search footer and you either type a new term or select categories/indexers, the entire table rerenders (as shown below)
Now on type this is the result
What I have done is address this from two angles, first I've moved it over to a functional component to better control the rerendering and to act as another example for how this works. Additionally, I've reworked the way that
onChangeworks for each component so it doesn't triggeronInputChangewhich was the issue component.As a side effect it also now doesn't lag on type as it did before.
Fixes #290
Fixes #293