Replace boost::optional with std::optional #6611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 20, 2023 16:04
6 tasks
added 2 commits
April 24, 2023 19:10
Must have been lost while concating everything into one commit
Seems like my local build is ok, but in CI the references to engine are still there so I am reverting code in /nodejs to master
mugr1x
force-pushed
the
boost_optional_merge
branch
from
03323e5
to
1107a14
Compare
mjjbell
requested changes
Aug 20, 2023
SiarheiFedartsou
approved these changes
May 21, 2024
|
👍🏽 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This PR target at (partially) resolving #6551.
That is exchanging boost::optional for std::optional from C++17.
As mentioned elsewhere (#6429 (comment))
boost::spirit::qi does not work with std::optional, however boost::spirit::x3 does.
This PR does NOT refactor these parts of the codebase. To my knowledge there are three parsers written with ::qi (and ::phoenix) and at least the time validator and CSV parser I was abled to at least work on. (not included in this PR)
However the core API of /server alses uses ::qi and changing this would be a more peculiar if not a bad decision (for now).
Note because of failing CI this is #6593 reopened.
Tasklist