Deprecate and rename respawn option to autoRespawn
#3280
Conversation
zardoy
changed the title
respawn options to autoRespawnrespawn option to autoRespawn
lib/loader.js
Outdated
| @@ -70,7 +70,7 @@ function createBot (options = {}) { | |||
| options.loadInternalPlugins = options.loadInternalPlugins ?? true | |||
| options.client = options.client ?? null | |||
| options.brand = options.brand ?? 'vanilla' | |||
| options.respawn = options.respawn ?? true | |||
| options.autoRespawn = options.autoRespawn ?? options.autoRespawn ?? true | |||
There was a problem hiding this comment.
Incorrect logic
Also, the doc seems already pretty clear. Is there anyone that's been confused by this?
|
why is it worth it to do such a breaking change for a minor renaming? |
where did you find the breaking change? the pr is here because of #3276 (comment), if for some reason you don't like it feel free to close it... |
|
Removing the option |
But I didn't remove support for options.respawn, old option should still be supported. am I missing something? |
|
ah yeah I see, yeah then it's not breaking not sure if it's really useful though, but maybe... |
|
Closing this so you can prioritize a lot of other more important prs |
fixes #3276