Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dimensionChange event #3275

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

IceTank
Copy link
Contributor

@IceTank IceTank commented Jan 4, 2024

This event is useful as not all emitted respawn events mean a dimension change. This event also emits when a login packet is send as not all login packets cause a spawn event to be emitted.

This pull request also changes some inconsistencies in how dimensions are named. Previously the nether and the end where sometimes refereed to as nether and end instead of the_nether and the_end. Minecraft always named them as the_nether and the_end.
This pull request also fixes a bug where worldName would sometimes not change after a dimension has been changed.

@IceTank
Copy link
Contributor Author

IceTank commented Jan 5, 2024

I fixed failing tests locally. Can push later.

@rom1504 rom1504 added this to Needs triage in PR Triage Jan 6, 2024
@rom1504 rom1504 moved this from Needs triage to Waiting for user input in PR Triage Jan 6, 2024
@rom1504
Copy link
Member

rom1504 commented Jan 6, 2024

waiting for fix

@rom1504
Copy link
Member

rom1504 commented Jan 7, 2024

/fixlint

@rom1504bot
Copy link
Contributor

I fixed all linting errors with npm run fix!

@rom1504
Copy link
Member

rom1504 commented Jan 7, 2024

CI is failing, errors are relevant to the change here

@IceTank
Copy link
Contributor Author

IceTank commented Jan 7, 2024

Yes Ill look more into it. It works for me but maybe the github runner needs more time for some stuff.

@rom1504
Copy link
Member

rom1504 commented Jan 7, 2024

  2) mineflayer_external 1.14.4v
       nether nether dimension change event:

      AssertionError [ERR_ASSERTION]: 'overworld' == 'the_nether'

and raytrace test failures

doesn't seem like timing to me

const dimensionNames = {
'-1': 'minecraft:nether',
const dimensionIdentifiers = {
'-1': 'minecraft:the_nether',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure its the_nether and not world_nether?

@extremeheat
Copy link
Member

extremeheat commented May 11, 2024

I updated the tests to use the proper assertion methods, so it's easier to see the test mismatches. Could be that the dimension rename is breaking things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
PR Triage
  
Waiting for user input
Development

Successfully merging this pull request may close these issues.

None yet

5 participants