Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to get the total xp points the bot has. #3124

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

zisis912
Copy link
Contributor

@zisis912 zisis912 commented Jul 27, 2023

Unlike its title, the bot.experience.points property does NOT provide one with the xp points the bot has, but rather its score, displayed only when one dies.

image

This PR adds a function that does precisely that, correctly get the bot's xp points.

That of course would make the .points property useless, so I would suggest you accept #3125 too if backwards compatibility is not an issue

@rom1504 rom1504 added this to Needs triage in PR Triage Jul 29, 2023
@rom1504
Copy link
Member

rom1504 commented Jul 29, 2023

/fixlint

@rom1504bot
Copy link
Contributor

I fixed all linting errors with npm run fix!

@rom1504
Copy link
Member

rom1504 commented Jul 29, 2023

@zisis912 please fix the lint with above command

@rom1504
Copy link
Member

rom1504 commented Jul 29, 2023

actually fixed

please add this function to the doc

@rom1504 rom1504 moved this from Needs triage to Waiting for user input in PR Triage Jul 29, 2023
@rom1504
Copy link
Member

rom1504 commented Dec 30, 2023

@zisis912 would you like to finish this?

@rom1504 rom1504 moved this from Waiting for user input to Almost too old in PR Triage Dec 31, 2023
@zisis912
Copy link
Contributor Author

I am a bit busy yhese days, maybe in a few docs i will get around to making docs for all of my PRs so they can be finished.

@zisis912
Copy link
Contributor Author

@rom1504 sorry but I really cant get myself to write documentation for all that stuff, however I would like to mention that

#3121 is an absolute dependency for this so I would urge you to merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
PR Triage
  
Almost too old
Development

Successfully merging this pull request may close these issues.

None yet

3 participants