Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete instaces tmp diectory on startup #2390

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Trial97
Copy link
Member

@Trial97 Trial97 commented May 10, 2024

The .tmp folder that is inside the instance folder should not exist or be empty.
This ensures that the mentioned folder will be deleted on launch

Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
@Trial97 Trial97 added enhancement New feature or request simple change changelog:added A PR that appears under "Added" in the changelog labels May 10, 2024
@Trial97 Trial97 added this to the 9.0 milestone May 10, 2024
Copy link
Member

@TayouVR TayouVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this one used when downloading or updating instances?
Either way, cleaner would be if we used the system temp, or QTemporaryFile or smth.

But that doesn't really matter here, clearing it on start makes sense ^^

@Trial97
Copy link
Member Author

Trial97 commented May 11, 2024

Yes it's the folder we use for update/create instances.
No we can't use the qtemp folder as that would require to add another step in the instance creation/update(copy the files from temp to instances). Right now due to files being on same partition we can just rename with 0 cost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:added A PR that appears under "Added" in the changelog enhancement New feature or request simple change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants