fix(nix): drop unsupported Qt 5 package #2361
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Trial97
approved these changes
Apr 30, 2024
timoreo22
approved these changes
May 5, 2024
Trial97
added
changelog:removed
TayouVR
approved these changes
May 8, 2024
getchoo
requested changes
May 8, 2024
| nixpkgs.url = "github:nixos/nixpkgs/nixpkgs-unstable"; | ||
| nixpkgs.url = "github:NixOS/nixpkgs/nixos-unstable"; |
There was a problem hiding this comment.
why the switch to nixos-unstable? this is meant to be used in and outside of nixos itself, so we should be sticking with nixpkgs-unstable here
There was a problem hiding this comment.
I wanted to use nixos-unstable as the chance of a cache hit is higher for those who use the overlay
There was a problem hiding this comment.
the only cache misses i'd imagine we'd get are in some of the inputs for the linux wrapper, but it hasn't ever really been an issue in my experience. i think it might be better to just keep this for darwin users and be slightly more up to date (it'd also fix the current merge conflict :p)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See NixOS/nixpkgs#305556