New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List image append #2346
base: develop
Are you sure you want to change the base?
List image append #2346
Conversation
Signed-off-by: SabrePenguin <lknofczynski@gmail.com>
Signed-off-by: SabrePenguin <lknofczynski@gmail.com>
Did you look at:#2341? |
I did. This fixes a different issue, which I mentioned on Discord two days ago. #2341 fixes image width. This fixes images being forcefully appended to lists when they shouldn't. |
Can you still reproduce the mentioned issue with my PR? If yes can you also do a screenshot and explain what is wrong? |
This does look like an issue but I'm sure that is not with prism but cmark |
It's not with cmark. I did testing and the generated html displays properly with both firefox and chromium. I don't know how Prism handles end of lists, but some pages have this bug, while others don't. |
So this is likely an issue with Qt? |
It's likely that Qt is at fault. But I'm not used to using Qt, so I can't really test effectively with it yet. |
From what I can tell this is indeed a QT bug. |
Also because this is a QT bug we should consider extracting this code in a separate function, and instead of having it be called here to be called each time we call |
Co-authored-by: Alexandru Ionut Tripon <alexandru.tripon97@gmail.com> Signed-off-by: SabrePenguin <147069705+SabrePenguin@users.noreply.github.com>
Co-authored-by: Alexandru Ionut Tripon <alexandru.tripon97@gmail.com> Signed-off-by: SabrePenguin <147069705+SabrePenguin@users.noreply.github.com>
Co-authored-by: TheKodeToad <TheKodeToad@proton.me> Signed-off-by: SabrePenguin <147069705+SabrePenguin@users.noreply.github.com>
Signed-off-by: SabrePenguin <lknofczynski@gmail.com>
Signed-off-by: SabrePenguin <lknofczynski@gmail.com>
Signed-off-by: SabrePenguin <lknofczynski@gmail.com>
Signed-off-by: SabrePenguin <lknofczynski@gmail.com>
Signed-off-by: SabrePenguin <lknofczynski@gmail.com>
Co-authored-by: TheKodeToad <TheKodeToad@proton.me> Signed-off-by: SabrePenguin <147069705+SabrePenguin@users.noreply.github.com>
Signed-off-by: SabrePenguin <lknofczynski@gmail.com>
Adds a break tag between and that prevents the tag from being forced into the last list item when generating html from markdown.
This prevents an issue which is visible from #2155