chore(README): fix up conditional logo rendering #2199
+2
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A really simple 1 liner change, which has been annoying me a bit lately.
This PR makes use of GitHub's provided theme URL fragments, instead of separate conditional media sources which was previously used, and didn't seem to apply correctly for me sometimes (see below). I was able to reproduce this without any userCSS themes as well.
Overall, I just think it makes more sense to offload things like this to GitHub themselves, instead of handling it on our own.