Goodbye qt5 #2174
Goodbye qt5 #2174
Conversation
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
| qt_modules: 'qt5compat qtimageformats' | ||
| qt_tools: '' | ||
|
|
||
| - os: macos-12 |
There was a problem hiding this comment.
I think we should still have a macos-legacy build built for macos 10.14 as the target with Qt 6.4.3 (last version that still supported macOS 10.14 and 10.15)
There was a problem hiding this comment.
aren't those both EOL? i think it might be good to just rip the band aid off now with qt5, especially since it would give us an easier time in bumping our qt6 version across the board (which was already brought up, though not happening just yet)
There was a problem hiding this comment.
A good amount of people still use the macos-legacy build of Prism Launcher so I think we should still have it as an option for now.
There was a problem hiding this comment.
according to the download counts of release 8.0, it only made up ~8.35% of all macOS users. in comparison, we dropped windows legacy builds after 7.2 when they were ~2.88% of downloads (see the full stats here, might have got my math wrong lol). i don't think the difference here is super significant; and given that windows 8 support was dropped less than a year after it's EOL date, i would also say this follows precedent as 10.15 has been EOL for a year and a half now, with 10.14 slowly getting to 3
at the very least, we should be fairly ready to drop these versions when the time comes to bump our Qt version. i would just prefer to be a bit more proactive about it and bundle it with other deprecations rather than be forced to drop it later down the line
There was a problem hiding this comment.
You do have a point. I agree that we should be prepared to drop macs-legacy, but I say that we shouldn't rush it. I know macos-legacy does come at the cost of maintainence, but I think we should discuss it more before dropping it.
There was a problem hiding this comment.
A big problem is that even Debian unstable is still stuck at Qt 6.4, I think it's too early to bump to 6.5
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
There was a problem hiding this comment.
@Scrumplex not sure if this should be included here. this will be the PR that completely ends support upstream, and i would hope we drop these from our packages before that point. maybe we can do this alongside the nixpkgs PR in time for 24.05 instead?
There was a problem hiding this comment.
This PR should probably just remove all references to the qt5 packages. We'll assume that those are already removed from Nixpkgs so no need to override them here.
Maybe I can prepare a PR that deprecates Qt 5 first
No description provided.