Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that core mods tab is visible on correct versions #2018

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Trial97
Copy link
Member

@Trial97 Trial97 commented Jan 7, 2024

fixes the described behavior from #2017 where the core mods tab is visible on the latest forge versions

Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
@Trial97 Trial97 added bug Something isn't working simple change changelog:fixed A PR that appears under "Fixed" in the changelog labels Jan 7, 2024
@TheKodeToad
Copy link
Member

wouldn't it be better to update the tab when Forge is downloaded than to do this?

@Trial97
Copy link
Member Author

Trial97 commented Jan 7, 2024

The tab will be visible until you start the game.
Right now if you open the edit window that tab is visible(for new instances that do not have the version yet loaded).And is only visible on first view(if you close the window and open it again that tab is no longer there)
So if we do this when forge is downloaded then it would be already too late.

@TheKodeToad
Copy link
Member

Forge's JSON file should automatically be downloaded 🤔

@Trial97
Copy link
Member Author

Trial97 commented Jan 15, 2024

Not really, it downloads but because it's async it is not instant resulting:

  • you open the window
  • if the file is not there download it
  • because we do not for it to download we display the core mods tab
    PS. Feel free to test it yourself(with and without my fix)

Copy link
Member

@TheKodeToad TheKodeToad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will cause a freeze which is worse than a delay. Please try an alternative like the one I suggested.

@TheKodeToad
Copy link
Member

**Not a freeze, still quite weird behaviour though imo

Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
@Trial97
Copy link
Member Author

Trial97 commented Jan 26, 2024

Fixed following you suggestion TheKobeToad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working changelog:fixed A PR that appears under "Fixed" in the changelog simple change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants