New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data pack management #1905

Draft

TheKodeToad wants to merge 1 commit into PrismLauncher:develop from TheKodeToad:data-packs

Member

TheKodeToad commented Dec 1, 2023 •

edited


          Data pack management

284e536

Signed-off-by: TheKodeToad <TheKodeToad@proton.me>

github-advanced-security bot found potential problems

View reviewed changes

launcher/minecraft/mod/DataPackFolderModel.cpp

Comment on lines +128 to +133

+                          switch (column) {
+                              case ActiveColumn:
+                                  return at(row)->enabled() ? Qt::Checked : Qt::Unchecked;
+                              default:
+                                  return {};
+                          }

Check notice

Code scanning / CodeQL

No trivial switch statements Note

This switch statement should either handle more cases, or be rewritten as an if statement.

TheKodeToad added this to the 9.0 milestone

TheKodeToad added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment