Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mod reinstall dialog #1892

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Trial97
Copy link
Member

@Trial97 Trial97 commented Nov 24, 2023

fixes #1354

Added one more button to the mods page that will open a dialog with the selected mod allowing you to select a new version to install.
Also added a tag to the installed version combobox to determine what is the installed version.

Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
@Trial97 Trial97 added enhancement New feature or request changelog:added A PR that appears under "Added" in the changelog labels Nov 24, 2023
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd recommend the button's name be changed to "change version" similar to the in version tab of instance settings - since that's a bit more descriptive, while "reinstall mod" sounds more like a troubleshooting method in the case a mod was installed incorrectly. it would also probably be nicer to have it near "check for updates" because of their similar functions

launcher/ui/pages/modplatform/ModPage.cpp Show resolved Hide resolved
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
Copy link
Member

@TayouVR TayouVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works 👍

@Trial97 Trial97 added this to the 9.0 milestone Feb 18, 2024
@getchoo getchoo self-requested a review March 27, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:added A PR that appears under "Added" in the changelog enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to Downgrade/Change Version of Installed Mods
3 participants