Adding sdkman java location to MacOs #2377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Samuel Stidham <dqfan2012@gmail.com>
Signed-off-by: Samuel Stidham <dqfan2012@gmail.com>
Trial97
approved these changes
May 6, 2024
Trial97
added
enhancement
1 task
DioEgizio
approved these changes
May 18, 2024
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're just adding support for sdkman to the MacOs version of the Prism Launcher here.
According to the install page on the sdkman website, sdkman does support installing Java on MacOs. As such, I think it's a good idea to add support to the Prism Launcher to find sdkman Java installations for those who use sdkman on MacOs to install Java.
This pull request solves this issue: #2336