Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-detection of Java installed through SDKMAN! on macOS #2336

Closed
1 task done
seji1 opened this issue Apr 24, 2024 · 3 comments · Fixed by #2377
Closed
1 task done

Auto-detection of Java installed through SDKMAN! on macOS #2336

seji1 opened this issue Apr 24, 2024 · 3 comments · Fixed by #2377
Labels
enhancement New feature or request

Comments

@seji1
Copy link

seji1 commented Apr 24, 2024

Operating System

macOS

Version of Prism Launcher

Prism Launcher 8.3

Version of Qt

Qt 6.6.3

Description of bug

This issue is very similar to #1477, but on macOS. Launcher won't detect jdks installed through sdkman.

Steps to reproduce

  • Install the launcher through Homebrew
  • Download sdkman via curl sdkman download docs
  • Install any jdk through sdkman on macOS
image
  • Try to auto-detect java installations in the launcher
image

Suspected cause

Maybe something similar to #1477?
Seems like #1682 was implemented incorrectly or affects only Linux.

This issue is unique

  • I have searched the issue tracker and did not find an issue describing my bug.
@seji1 seji1 added the bug Something isn't working label Apr 24, 2024
@Trial97
Copy link
Member

Trial97 commented Apr 26, 2024

This is not a bug: sdkman was not supported on mac by prism

@Trial97 Trial97 added enhancement New feature or request and removed bug Something isn't working labels Apr 26, 2024
@dqfan2012
Copy link
Contributor

dqfan2012 commented May 5, 2024

@Trial97

This is from the sdkman website: sdkman install page

image

sdkman isn't supported on Mac? That's not what their website seems to indicate.

Update

I thought this was an excellent moment to contribute to open source software and I created a pull request to address this situation in MacOs.

@Trial97
Copy link
Member

Trial97 commented May 6, 2024

What I meant is that prism did not support sdkman on Mac,like the original issue only required to implement it for Linux, so the issue is not a bug but an enchantment.
My statement was strictly directed to the label of the issue.

@Trial97 Trial97 linked a pull request May 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants