-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement: Adding UI for variables of any json type #2414
Conversation
…ary into variables-json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Mostly non-blocking comments - only 1 comment I think might need to be addressed around handling a variable edit/update from a clicked VariableLink. I think(?) I'm right there that atm you'd update and not see your updated data.
should i be reaching back into the types more than i am?
Hm 🤔 not sure what you mean.
Co-authored-by: Collin <collin@choy.me>
Co-authored-by: Collin <collin@choy.me>
I mean like should i be changing the types for variables from stringg to like string|int etc? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR:
For the team - should i be reaching back into the types more than i am?
All thoughts welcome, thanks.