Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix server tracing setting to use markdownDescription #4991

Merged
merged 1 commit into from
May 20, 2024

Conversation

ijre
Copy link
Contributor

@ijre ijre commented May 17, 2024

PR Summary

Changes the powershell.trace.server setting's description key to instead be markdownDescription; judging by the rest of the user settings in package.json, the usage of description seems unintentional.

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • [NA] PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@ijre ijre requested a review from a team as a code owner May 17, 2024 07:56
@andyleejordan andyleejordan changed the title Fix lang server tracing option to use markdownDescription Fix server tracing setting to use markdownDescription May 17, 2024
Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, we appreciate it!

@andyleejordan andyleejordan added this pull request to the merge queue May 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 20, 2024
@andyleejordan andyleejordan added this pull request to the merge queue May 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 20, 2024
@andyleejordan andyleejordan added this pull request to the merge queue May 20, 2024
Merged via the queue into PowerShell:main with commit 31712d9 May 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants