Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recalling a previous command via PSReadLine in VScode is unusable is the prompt contains U+231B in the CaskaydiaCove NF font #4948

Open
6 tasks done
sba923 opened this issue Mar 21, 2024 · 3 comments
Labels
Issue-Bug A bug to squash. Needs: Maintainer Attention Maintainer attention needed!

Comments

@sba923
Copy link

sba923 commented Mar 21, 2024

Prerequisites

  • I have written a descriptive issue title.
  • I have searched all open and closed issues to ensure it has not already been reported.
  • I have read the troubleshooting guide.
  • I am sure this issue is with the extension itself and does not reproduce in a standalone PowerShell instance.
  • I have verified that I am using the latest version of Visual Studio Code and the PowerShell extension.
  • If this is a security issue, I have read the security issue reporting guidance.

Summary

(Origin: JanDeDobbeleer/oh-my-posh#4786)

If the prompt contains the character U+231B (Hourglass) ⌛ (using the CaskaydiaCove NF font), when commands are recalled e.g. using the up arrow key, the rendering of the recalled command is incorrect, making editing the command basically impossible:

image

PowerShell Version

Name                           Value
----                           -----
PSVersion                      7.4.1
PSEdition                      Core 
GitCommitId                    7.4.1
OS                             Microsoft Windows 10.0.19045
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Name             : Visual Studio Code Host
Version          : 2024.0.0
InstanceId       : 0cbd41af-f26a-4ab5-9d9a-3d1da68d5ff6
UI               : System.Management.Automation.Internal.Host.InternalHostUserInterface
CurrentCulture   : en-US
CurrentUICulture : en-US
PrivateData      : Microsoft.PowerShell.ConsoleHost+ConsoleColorProxy
DebuggerEnabled  : True
IsRunspacePushed : False
Runspace         : System.Management.Automation.Runspaces.LocalRunspace

Visual Studio Code Version

1.87.2
863d2581ecda6849923a2118d93a088b0745d9d6
x64

Extension Version

ms-vscode.powershell@2024.0.0
tylerleonhardt.vscode-inline-values-powershell@0.0.7

Steps to Reproduce

  1. Use the following prompt function:

function prompt
{
("PS [{0}] ⌛ " -f (pwd).ProviderPath)
}

  1. recall a command line using PSReadLine that is longer than the available display width after the prompt

Visuals

No response

Logs

extensionlogs.zip

@andyleejordan
Copy link
Member

Hey @sba923 I'm curious if this is still happening with v2024.2.0? We now use VS Code's built-in Shell Integration script (instead of a port of it that we had to manually maintain).

@sba923
Copy link
Author

sba923 commented Apr 16, 2024

Hey @sba923 I'm curious if this is still happening with v2024.2.0? We now use VS Code's built-in Shell Integration script (instead of a port of it that we had to manually maintain).

I have disabled my workaround, can't seem to repro with v2024.2.0 or v2024.3.2 pre-release.

To be confirmed by continuous usage, I'll keep you posted.

@JustinGrote JustinGrote added Needs: Fix Verification Please verify the fix for us! and removed Needs: Triage Maintainer attention needed! labels Apr 16, 2024
@sba923
Copy link
Author

sba923 commented Apr 22, 2024

I hate to say, but I can repro on my Windows 10 work laptop:

image

image

I can't find relevant differences with my personal Windows 11 desktop where the problem apparently can't be repro'ed anymore...

Any clue?

@github-actions github-actions bot added Needs: Maintainer Attention Maintainer attention needed! and removed Needs: Fix Verification Please verify the fix for us! labels Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug A bug to squash. Needs: Maintainer Attention Maintainer attention needed!
Projects
None yet
Development

No branches or pull requests

3 participants