Recalling a previous command via PSReadLine in VScode with oh-my-posh 19.18.0 is unusable if using the executiontime segment
#4786
Comments
|
@sba923 does this happen outside of vscode? Because nothing changed on that end for a long time. |
|
No, it doesn't. |
|
Ok, so there no difference in what oh-my-posh does. VSCode however injects its own script when enabling shell integration, so disable that and see if the issue persists. |
|
What exact script are you referring to? Do you know how to disable it? |
|
It's this feature I'm referring to. |
|
I hate to say, but this doesn't solve the issue. It seems to be theme-dependent. The issue shows up as soon as I add this to my custom theme: {
"background": "#83769c",
"foreground": "#ffffff",
"properties": {
"always_enabled": true
},
"template": "\u231b{{ .FormattedMs }}\u2800",
"powerline_symbol": "\ue0b0",
"style":"powerline",
"type": "executiontime"
},So (apologies, will edit the title and description of the issue), this is not related to a recent |
sba923
changed the title
sba923
changed the title
executiontime segment
|
Current workaround in my if ($host.Name -match 'Visual Studio Code Host')
{
# VScode doesn't like oh-my-posh's "executiontime"
Write-Host -ForegroundColor Yellow 'Creating temp oh-my-posh theme file for VScode'
$theme = Get-Content ($env:PSHOME + '\PowerShell\oh-my-posh\Themes\sba.json') | ConvertFrom-Json
$theme.blocks = $theme.blocks | Foreach-Object {
$_.segments = $_.segments | Where-Object { $_.type -ne "executiontime" }
$_
}
$themefile = Join-Path -Path $env:TEMP -ChildPath 'sba-no-executiontime_oh-my-posh_theme.json'
$theme | ConvertTo-Json -Depth 10 | Out-File -LiteralPath $themefile
oh-my-posh init pwsh --config $themefile | Invoke-Expression
}
else
{
oh-my-posh init pwsh --config ($env:PSHOME + '\PowerShell\oh-my-posh\Themes\sba.json') | Invoke-Expression
}
|
|
@sba923 the segment can't be the issue but the glyphs can. Try removing those from the template and see if the issue persists. |
|
Bingo! That same thought had occurred to be, BTW. Replacing Now this could be a font issue (I'm using CaskadiaCove NF), an issue with the extension... Given that it's VScode only, I'll file an issue at https://github.com/PowerShell/vscode-powershell/issues. Changed my workaround to: if ($host.Name -match 'Visual Studio Code Host')
{
# VScode doesn't like the "hourglass" (U+231B) glyph
Write-Host -ForegroundColor Yellow 'Creating temp oh-my-posh theme file for VScode'
$theme = (Get-Content ($env:PSHOME + '\PowerShell\oh-my-posh\Themes\sba.json')) -replace '\\u231b', "" | ConvertFrom-Json
$themefile = Join-Path -Path $env:TEMP -ChildPath 'sba-no-hourglass_oh-my-posh_theme.json'
$theme | ConvertTo-Json -Depth 10 | Out-File -LiteralPath $themefile
oh-my-posh init pwsh --config $themefile | Invoke-Expression
}
else
{
oh-my-posh init pwsh --config ($env:PSHOME + '\PowerShell\oh-my-posh\Themes\sba.json') | Invoke-Expression
} |
|
@sba923 closing this as we can't solve that here. It's definitely a terminal issue, nothing a font can solve. |
Sure. To be continued at PowerShell/vscode-powershell#4948 |
Code of Conduct
What happened?
Since I added the
executiontimesegment to my custom theme, recalling and editing previous commands withPSReadLinewithin the VScode terminal has become... unusable.Theme
{ "$schema": "https://raw.githubusercontent.com/JanDeDobbeleer/oh-my-posh/main/themes/schema.json", "shell_integration": true, "blocks": [ { "alignment": "left", "segments": [ { "background": "#86e2f1", "foreground": "#2b2b2b", "leading_diamond": "\ue0b6", "style": "diamond", "type": "session" }, { "background": "#ff8c00", "foreground": "#ffffff", "powerline_symbol": "\ue0b0", "properties": { "style": "folder" }, "style": "powerline", "type": "path" }, { "background": "#0077c2", "foreground": "#ffffff", "powerline_symbol": "\ue0b0", "properties": { "mapped_shell_names": { "pwsh": "PS" } }, "style": "powerline", "type": "shell", "template": "{{ if ne .Shell \"pwsh\" }} {{ .Name }} {{ end }}" }, { "background": "#cf9e11", "foreground": "#ffffff", "powerline_symbol": "\ue0b0", "style": "powerline", "type": "text", "template": "{{ if .WSL }} {{ \"WSL\" }} {{ end }}" }, { "background": "#fffb38", "background_templates": [ "{{ if or (.Working.Changed) (.Staging.Changed) }}#FF9248{{ end }}", "{{ if and (gt .Ahead 0) (gt .Behind 0) }}#ff4500{{ end }}", "{{ if gt .Ahead 0 }}#B388FF{{ end }}", "{{ if gt .Behind 0 }}#B388FF{{ end }}" ], "foreground": "#193549", "powerline_symbol": "\ue0b0", "properties": { "branch_max_length": 25, "fetch_stash_count": true, "fetch_status": true, "fetch_upstream_icon": true }, "style": "powerline", "template": " {{ .UpstreamIcon }}{{ .HEAD }}{{if .BranchStatus }} {{ .BranchStatus }}{{ end }}{{ if .Working.Changed }} \uf044 {{ .Working.String }}{{ end }}{{ if and (.Working.Changed) (.Staging.Changed) }} |{{ end }}{{ if .Staging.Changed }} \uf046 {{ .Staging.String }}{{ end }}{{ if gt .StashCount 0 }} \uf692 {{ .StashCount }}{{ end }} ", "trailing_diamond": "\ue0b4", "type": "git" }, { "background": "#6CA35E", "foreground": "#ffffff", "powerline_symbol": "\ue0b0", "properties": { "fetch_version": true }, "style": "powerline", "template": " \uf898 {{ if .PackageManagerIcon }}{{ .PackageManagerIcon }} {{ end }}{{ .Full }} ", "type": "node" }, { "background": "#6CA35E", "foreground": "#ffffff", "powerline_symbol": "\ue0b0", "properties": { "fetch_version": true }, "style": "powerline", "type": "dotnet" }, { "background_templates": [ "{{if contains \"default\" .Profile}}#FFA400{{end}}", "{{if contains \"jan\" .Profile}}#f1184c{{end}}" ], "foreground": "#ffffff", "powerline_symbol": "\ue0b0", "properties": { "display_default": false }, "style": "powerline", "template": " \ue7ad {{ .Profile }}{{ if .Region }}@{{ .Region }}{{ end }} ", "type": "aws" }, { "background": "#ff0000", "foreground": "#ffff66", "powerline_symbol": "\ue0b0", "style": "powerline", "type": "root" }, { "background": "#83769c", "foreground": "#ffffff", "properties": { "always_enabled": true }, "template": "\u231b{{ .FormattedMs }}\u2800", "powerline_symbol": "\ue0b0", "style":"powerline", "type": "executiontime" }, { "background": "#2e9599", "background_templates": [ "{{ if (ne .Code 0) }}#f1184c{{ end }}" ], "foreground": "#ffffff", "powerline_symbol": "\ue0b0", "properties": { "always_enabled": true, "status_template": "{{ if ne .Code 0 }}\uf071 ({{ if or (gt .Code 255) (lt .Code 0) }}{{ .Code | hresult }}{{ else }}{{.Code}}{{ end }}){{ else }}\uf00c{{ end }}", "status_separator": " " }, "style": "diamond", "trailing_diamond": "\ue0b4", "type": "status" } ], "type": "prompt" }, { "alignment": "right", "segments": [ { "background": "#f36943", "background_templates": [ "{{if eq \"Charging\" .State.String}}#40c4ff{{end}}", "{{if eq \"Discharging\" .State.String}}#ff5722{{end}}", "{{if eq \"Full\" .State.String}}#4caf50{{end}}" ], "foreground": "#ffffff", "leading_diamond": "\ue0b6", "properties": { "charged_icon": "\ue22f ", "charging_icon": "\ue234 ", "discharging_icon": "\ue231 " }, "style": "diamond", "template": " {{ if not .Error }}{{ .Icon }}{{ .Percentage }}{{ end }}{{ .Error }}\uf295 ", "type": "battery" }, { "background": "#2e9599", "foreground": "#111111", "powerline_symbol": "\ue0b0", "style": "plain", "template": "<background,parentBackground>{{ if .Segments.Contains \"Battery\" }}\ue0b2{{ else }}\ue0b6{{ end }}</> {{ .CurrentDate | date .Format }} <background,transparent>\ue0b4</>", "type": "time" } ], "type": "rprompt" } ], "final_space": true, "version": 2, "console_title": true, "console_title_template": "{{ .Folder }}", "console_title_style": "template" }What OS are you seeing the problem on?
Windows
Which shell are you using?
powershell
Log output
The text was updated successfully, but these errors were encountered: