New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove add command #670

Draft

anamnavi wants to merge 56 commits into PowerShell:master from anamnavi:remove-ADD-command

Member

anamnavi commented Jun 6, 2022 •

edited

PR Summary

For internal compliance reasons we will not be downloading the powershell package from online (through ADD or curl) directly into our images.

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Change is not breaking
Make sure all Dockerfile, .sh, .ps1 and .psm1 files have the correct copyright header
This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

anamnavi added 9 commits

May 18, 2022 13:47


          remove ADD command

68c1430


          use wget on alpine, install ca-certificates on mariner before curl

48542a9


          use wget for alpine,install ca-certificates to use curl for mariner a…

123c11e

…nd update image sizes for 7-3


          update debian 10

4fe6f99


          install appropriate powershell installer file to docker context for e…

5e94eaf

…ach dockerfile


          merge changes from master, resolve merge conflicts

51b7a9f


          update dockerfile code

4df41d0


          pull master, resolve merge conflicts

78fc553


          updte ubuntu20 and ubuntu22 to not use ADD

6553aca

anamnavi requested a review from TravisEz13 as a code owner

June 6, 2022 18:00

anamnavi changed the title ~~Remove add command~~ WIP: Remove add command

TravisEz13 reviewed

View reviewed changes

tools/buildHelper/buildHelper.psm1 Outdated Show resolved Hide resolved

TravisEz13 reviewed

View reviewed changes

release/unstable/clearlinux/docker/Dockerfile Outdated Show resolved Hide resolved

TravisEz13 reviewed

View reviewed changes

release/unstable/blackarch/docker/Dockerfile Outdated Show resolved Hide resolved

Member Author

anamnavi commented Jun 6, 2022

I'll look at the WebClient DownloadFile() error later today

TravisEz13 reviewed

View reviewed changes

release/7-3/ubuntu22.04/docker/Dockerfile Show resolved Hide resolved

TravisEz13 reviewed

View reviewed changes

release/7-3/debian11/docker/Dockerfile Show resolved Hide resolved

anamnavi added 4 commits

June 8, 2022 13:45


          use PackageFormat instead of hardcoded paths to determine path for po…

6145b0c

…wershell installer


          clean up extra ARG code in mariner image

36a6461


          ubuntu20 update meta.json to specify .deb in PackageFormat

cb007a5


          use ENV var instead of ARG var in Ubuntu22

f3e3761

Collaborator

RDIL commented Jun 8, 2022

What exactly is the reasoning behind this change?

Member Author

anamnavi commented Jun 8, 2022

@RDIL for internal compliance reasons we don't want to be downloading powershell package from online (through ADD or curl) directly into our images

Collaborator

RDIL commented Jun 8, 2022

What is the plan for getting the package into the images then?

Member Author

anamnavi commented Jun 8, 2022

@RDIL users will run the build script first, which will download the powershell installer file, then in the image we copy that installer file in and install the package.

anamnavi added 5 commits

June 14, 2022 02:28


          reduce debian image size by using mount

b9f15fc


          debian 10,11 for 7-2,7-3 should use mount to minimize image size

05edf24


          ubuntu20 and ubuntu22 should use mount to reduce image size

71800fc


          mariner2 7-2 should use mount, mariner2 7-3 clean up

32ea65e


          ubuntu22 and ubuntu20 clean up

7c294da

anamnavi added 2 commits

August 3, 2022 13:24


          fix typo

32387f6


          merge changes from master, resolve merge conflicts

89ac18d

TravisEz13 marked this pull request as draft

August 3, 2022 18:33

anamnavi added 27 commits

August 8, 2022 10:52


          channelTag param should not be mandatory in helper method as can be n…

bf726a1

…ull or empty string


          allmeta.meta.PackageFormat would be empty for test-deps images so mov…

4154e9d

…e code to correct condition


          see why download of pwsh installer file is failing

f05c075


          add try catch around downloadFile()

908b869


          simplify catch

1f0b8d5


          remove verbose statement

fd568a4


          clean up code comments

206a6d2


          fix typos in powershell release file generation

e122b2e


          remove typo from powershell installer uri

4cd013d


          remove commented out code

06bb17c


          output more vars in throw

b9681df


          output more vars in throw

5b91b3f


          set powershell installer file url with container name

f86e8d0


          clear channeltag so previous channel tag does not persist and selecti…

44a9601

…vely add v prior to container name version


          define powershell package instller url separately

2806f44


          fix typo that adds extra slash in powershell installer uri

9d91ff8


          add channelTag to packageFormat in images meta json file

9bc9c34


          only rpm an deb file extension package formats need chaa\nnelTag

b6cfad9


          v character prepended to version should not be present in package for…

0b63a64

…mat name


          fixunderscoring for rpm

506a8a6


          fix underscoring and 'v' being added to create package url properly

0aa78ff


          add try catch around downloadFile() call

ba35bff


          add / in url

601e66d


          clean up code

3801a6d


          reset channelTag each time Get-TestParams method is entered to hopefu…

1bf8057

…lly clear preview channel for non preview psversion url


          change unittests to use current preview and stable versions instead o…

999fd62

…f hardcoded 7.2.2


          reset channelData when channeltag is set and write warning instead of…

7960dfc

… throwing for incorrect package format names

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment