Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pat token fix #1599

Merged
merged 3 commits into from
Apr 12, 2024
Merged

Pat token fix #1599

merged 3 commits into from
Apr 12, 2024

Conversation

gerryleys
Copy link
Contributor

@gerryleys gerryleys commented Mar 13, 2024

PR Summary

PR Context

PR Checklist

@gerryleys
Copy link
Contributor Author

@gerryleys please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree [company="KU Leuven"]

@gerryleys
Copy link
Contributor Author

@microsoft-github-policy-service agree

@gerryleys
Copy link
Contributor Author

PS SecretStore 'SecureString' object is governed as a (PAT) token, instead of parsed to a PSCredential Object and treathed as a 'username/password' auth. (Issue #1593)
This 'token' will translate into a HttpClient 'Basic Authorization' to access an Azure Devops onprem private artifcats feed.

@alerickson
Copy link
Member

@gerryleys thanks for opening up this PR. There seems to be some build issues, can't tell what's going on from the CI validation, but please run .\build.ps1 -Clean -Build -BuildConfiguration Debug on the root directory to view and fix errors.

@gerryleys
Copy link
Contributor Author

@alerickson Any update on the fix? Is there something I can do (or forgot to do) for this PR? Thanks in advance.

@alerickson
Copy link
Member

/azp run PowerShell.PSResourceGet

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@alerickson alerickson merged commit 07896d1 into PowerShell:master Apr 12, 2024
11 checks passed
alerickson pushed a commit that referenced this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants