This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
Fix issue #30 #46
Closed
Fix issue #30 #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Julien -- I'll take a closer look this week and get this merged in. How would we suggest people opt out of this feature if they don't want the risk of killing the process? Set the timeout to |
|
Hello Ryan,
You are right, we need an option to opt out. I think setting the timeout to
0 is the most intuitive way.
I’ll modify my PR the next weekend.
Have a nice day.
…On Mon, 14 May 2018 at 05:57, Ryan Puffer ***@***.***> wrote:
Thanks Julien -- I'll take a closer look this week and get this merged in.
How would we suggest people opt out of this feature if they don't want the
risk of killing the process? Set the timeout to [int]::MaxValue or null?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#46 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AI4kpGDf3w8-7dHz6RoMg3dri3rW_kv-ks5tyQ7LgaJpZM4T55oi>
.
|
|
Disabling WinRM workaround (process killing) is implemented: when HungRegistrationTimeout is set to 0, no process is killed. |
TravisEz13
reviewed
Jul 6, 2018
| { | ||
| # Temporary disabling Verbose as xxx-PSSessionConfiguration methods verbose messages are useless for DSC debugging | ||
| $VerbosePreferenceBackup = $Global:VerbosePreference | ||
| $Global:VerbosePreference = 'SilentlyContinue' |
There was a problem hiding this comment.
Can this be changed to the script scope?
TravisEz13
reviewed
Jul 6, 2018
| { | ||
| # Temporary disabling Verbose as xxx-PSSessionConfiguration methods verbose messages are useless for DSC debugging | ||
| $VerbosePreferenceBackup = $Global:VerbosePreference | ||
| $Global:VerbosePreference = 'SilentlyContinue' |
TravisEz13
reviewed
Jul 6, 2018
|
|
||
| if ($Path) | ||
| { | ||
| $registerString = "`$null = Register-PSSessionConfiguration -Name '$Name' -Path '$Path' -Force -ErrorAction 'Stop' -WarningAction 'SilentlyContinue'" |
There was a problem hiding this comment.
Can we use a static script block with parameters and the argument list to Start-job?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This is my fix proposal for issue #30.
Before registering the PSSessionConfiguration, we save the list of services running in the same process as WinRM + services depending from them.
We let Register-PSSessionConfiguration command 10 seconds to complete. If it not complete in 10 seconds and the WinRM service is in the state 'Stopping', we kill the process hosting WinRm service and then restart all services impacted.
This change is