New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Preventing mousewheel from altering port value in batch export form #22258
refactor: Preventing mousewheel from altering port value in batch export form #22258
Conversation
in batch export edit form
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but not to TypeScript who complain about something...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but not to TypeScript who complain about something...
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
Size Change: -14.6 kB (-1.39%) Total Size: 1.03 MB
|
Problem
A user pointed out (in ZenDesk ticket 11999) that the value in the port number field, in the batch export config screen, can be changed unintentionally by scrolling with the mouse wheel. This PR is to prevent that by changing the field type from
number
totel
.Changes
Changed field type from
number
totel
on line 371 offrontend/src/scenes/batch_exports/BatchExportEditForm.tsx
Before:
After:
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Tested on my local (see the 'after' gif above)
Note
Codespaces became displeased with the branch I used for PR https://github.com/PostHog/posthog/pull/22051, hence this new PR from a new branch.