Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Preventing mousewheel from altering port value in batch export form #22258

Merged
merged 2 commits into from May 24, 2024

Conversation

slshults
Copy link
Contributor

Problem

A user pointed out (in ZenDesk ticket 11999) that the value in the port number field, in the batch export config screen, can be changed unintentionally by scrolling with the mouse wheel. This PR is to prevent that by changing the field type from number to tel.

Changes

Changed field type from number to tel on line 371 of
frontend/src/scenes/batch_exports/BatchExportEditForm.tsx

Before:
before-number

After:
CleanShot 2024-05-02 at 14 21 16

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

Tested on my local (see the 'after' gif above)

Note

Codespaces became displeased with the branch I used for PR https://github.com/PostHog/posthog/pull/22051, hence this new PR from a new branch.

@slshults slshults changed the title Preventing mousewheel from altering port value in batch export form refactor: Preventing mousewheel from altering port value in batch export form May 10, 2024
Copy link
Collaborator

@mariusandra mariusandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but not to TypeScript who complain about something...

Copy link
Collaborator

@mariusandra mariusandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but not to TypeScript who complain about something...

@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@Twixes
Copy link
Collaborator

Twixes commented May 20, 2024

@slshults

@slshults
Copy link
Contributor Author

@slshults

Thanks for the ping @Twixes . this is still on my radar, but I am currently prioritizing responding to support tickets which have been waiting too long for replies since we were on our offsite.

@posthog-bot posthog-bot removed the stale label May 21, 2024
@slshults slshults requested a review from mariusandra May 23, 2024 23:15
Copy link
Contributor

Size Change: -14.6 kB (-1.39%)

Total Size: 1.03 MB

Filename Size Change
frontend/dist/toolbar.js 1.03 MB -14.6 kB (-1.39%)

compressed-size-action

@slshults slshults merged commit ef4ecaf into master May 24, 2024
83 checks passed
@slshults slshults deleted the slshults-change-port-field-from-num-to-tel-2 branch May 24, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants