New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(data-warehouse): data warehouse logic/data refactor #22254
Conversation
Size Change: 0 B Total Size: 1.05 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a bit of QA and looks good! Glad you're getting this refactor in before beta release. Left a comment about tests on one function
|
||
def serialize_database( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we test this function at all? Seems like a good bit of logic we want to keep set
@@ -1,99 +0,0 @@ | |||
import { afterMount, connect, kea, listeners, path, selectors } from 'kea' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hah finally this horrible name is gone
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
* WIP * Removed unused type * Added view support * Get join info working better for external tables * Updated mypy * Added tests * Updated mypy * Fixed tests * Fixes for visual tests
Problem
Changes
DatabaseSchema
HogQL query and extends it to support all table types along with a new response structure to fulfill all the frontend needsSavedQueries
logicTODO
DatabaseSchema
query endpointDoes this work well for both Cloud and self-hosted?
Yes
How did you test this code?