Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pipeline node logs kea logic types #22252

Merged
merged 2 commits into from May 23, 2024
Merged

Conversation

tiina303
Copy link
Contributor

Problem

This was the only logic with different way to use loaders and it was also wrong, the type of PluginLogEntry[] | BatchExportLogEntry[] is not the same as (BatchExportLogEntry | BatchExportLogEntry)[].

There was a typing error in the app source code file too, not sure who fixed prettier or what changed.

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

Copy link
Contributor

Size Change: -14.8 kB (-1.41%)

Total Size: 1.03 MB

Filename Size Change
frontend/dist/toolbar.js 1.03 MB -14.8 kB (-1.41%)

compressed-size-action

@tiina303 tiina303 merged commit 231a10e into master May 23, 2024
80 checks passed
@tiina303 tiina303 deleted the unify-pipeline-node-logs branch May 23, 2024 14:22
xrdt pushed a commit that referenced this pull request May 24, 2024
timgl pushed a commit that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants