fix: Move TEMPORAL_HOST to docker-compose.hobby.yml #22240
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Self-hosted installation has been broken out-of-the-box for more than a year now due to overwriting (not merging) of
environment
section insideposthog/docker-compose.base.yml
: thetemporal-django-worker
dict extends the&worker
reference, but then overwrites the environment to setTEMPORAL_HOST: temporal
instead of merging. See #16169 (comment) for details.Changes
Ditch
environment
section in posthog/docker-compose.base.yml and moveTEMPORAL_HOST
to docker-compose.hobby.ymlDoes this work well for both Cloud and self-hosted?
self-hosted
How did you test this code?
Had to do this manually per each install and it's wearing me thin.