Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move TEMPORAL_HOST to docker-compose.hobby.yml #22240

Closed
wants to merge 3 commits into from

Conversation

feedanal
Copy link
Contributor

@feedanal feedanal commented May 10, 2024

Problem

Self-hosted installation has been broken out-of-the-box for more than a year now due to overwriting (not merging) of environment section inside posthog/docker-compose.base.yml: the temporal-django-worker dict extends the &worker reference, but then overwrites the environment to set TEMPORAL_HOST: temporal instead of merging. See #16169 (comment) for details.

Changes

Ditch environment section in posthog/docker-compose.base.yml and move TEMPORAL_HOST to docker-compose.hobby.yml

Does this work well for both Cloud and self-hosted?

self-hosted

How did you test this code?

Had to do this manually per each install and it's wearing me thin.

move
            TEMPORAL_HOST: temporal
to 
 docker-compose.hobby.yml
remove             TEMPORAL_HOST: temporal
Update docker-compose.hobby.yml
@benjackwhite benjackwhite changed the title move TEMPORAL_HOST to docker-compose.hobby.yml fix: Move TEMPORAL_HOST to docker-compose.hobby.yml May 10, 2024
@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@fuziontech
Copy link
Member

hey @feedanal! Thanks for flagging this and sorry for the slow response. Solid catch that we are paving over that environment setting on the docker-compose stack. I'd rather not just pull this out from the base and put it in hobby since we honestly have a few docker-compose configs based on this base (that's why it's there!)

I've gone ahead and aliased the worker_env directly so that those blocks are extended and not just paved over.

#22367

@fuziontech fuziontech closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants