fix: Significantly reduce logging of hobby clickhouse #22239
Merged
+25
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default ALL logging is enabled, sometimes at trace level, which results in gigabytes of logs daily for an average website. This commit reduces max log size and increases logging level to `error`.
benjackwhite
changed the title
fuziontech
approved these changes
May 10, 2024
timgl
pushed a commit
that referenced
this pull request
May 21, 2024
significantly reduce logging By default ALL logging is enabled, sometimes at trace level, which results in gigabytes of logs daily for an average website. This commit reduces max log size and increases logging level to `error`.
thmsobrmlr
pushed a commit
that referenced
this pull request
May 21, 2024
significantly reduce logging By default ALL logging is enabled, sometimes at trace level, which results in gigabytes of logs daily for an average website. This commit reduces max log size and increases logging level to `error`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
By default ALL Clickhouse logging is enabled, sometimes at trace level, which results in gigabytes of logs daily for an average website.
Might be one of the causes for #20101
Changes
This commit reduces max log size and increases logging level to
error.How did you test this code?
Running all my Clickhouse instances with this config.