fix(plugin-server): assert fields we iterate over are objects #22201
+73
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
|
This PR was closed due to lack of activity. Feel free to reopen if it's still relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP that will require tests to be updated if we actually want to merge it.
However, it [seems to me that capture-rs will reject events] if the user sends a string as the toplevel
properties,$set, or$set_once. We could just add an assertion forproperties.$setandproperties.$set_onceand reject those events too, which seems cleaner...Anyone have opinions on whether we should just reject these events as misshapen in capture?
Worth noting that Python capture definitely doesn't require (or check) that these are objects, to our detriment: https://posthog.sentry.io/issues/5321764413/