Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(data-warehouse): Condensed joins UI #22190

Merged
merged 8 commits into from May 20, 2024
Merged

chore(data-warehouse): Condensed joins UI #22190

merged 8 commits into from May 20, 2024

Conversation

Gilbert09
Copy link
Contributor

Problem

  • We had tabs in the data warehouse scene, one for the tables and another for managing joins
  • We want to move the warehouse stuff into data pipelines 3000, and so getting rid of the joins tab would make the transition much easier

Changes

  • Condensed the joins UI and logic into the tables views
  • Can edit and delete joins from the table (from the individual columns)
    • Works on both posthog and warehouse tables
  • Removed the Joins tab and relevant components
Screen.Recording.2024-05-08.at.17.01.07.mov

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

Browser clicks

@Gilbert09 Gilbert09 requested a review from EDsCODE May 8, 2024 15:02
Copy link
Contributor

github-actions bot commented May 8, 2024

Size Change: 0 B

Total Size: 1.05 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.05 MB

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@Gilbert09 Gilbert09 merged commit f7f65dc into master May 20, 2024
86 checks passed
@Gilbert09 Gilbert09 deleted the tom/joins-ui branch May 20, 2024 14:44
timgl pushed a commit that referenced this pull request May 21, 2024
* Condensed joins UI

* Updated mypy

* Updated mypy

* Updated mypy

* Update UI snapshots for `chromium` (2)

* Update UI snapshots for `chromium` (2)

* Fixed tests

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
thmsobrmlr pushed a commit that referenced this pull request May 21, 2024
* Condensed joins UI

* Updated mypy

* Updated mypy

* Updated mypy

* Update UI snapshots for `chromium` (2)

* Update UI snapshots for `chromium` (2)

* Fixed tests

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants