Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add match_action for plugin configs #22177

Merged
merged 9 commits into from May 22, 2024

Conversation

benjackwhite
Copy link
Contributor

Problem

Just the migration part of #22056

Changes

  • Adds new match action field for plugins

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@tiina303
Copy link
Contributor

tiina303 commented May 8, 2024

I'm not sure about the constraint failure for the migration 🤔

@benjackwhite benjackwhite requested review from neilkakkar and removed request for bretthoerner and tkaemming May 9, 2024 12:17
Copy link
Collaborator

@neilkakkar neilkakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice looks good! Just one commend to add

posthog/management/commands/test_migrations_are_safe.py Outdated Show resolved Hide resolved
@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@benjackwhite benjackwhite merged commit 43224a4 into master May 22, 2024
77 checks passed
@benjackwhite benjackwhite deleted the feat/action-webhooks-migration branch May 22, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants