Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow styling of placeholder on paper-input #676 #677

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

andria-dev
Copy link

Fixes #676

This fixes #676 by allowing developers to deliberately change just the color of the input's placeholder using --paper-input-container-input-placeholder-color.

This change would allow developers to deliberately change only the color of the input's placeholder using `--paper-input-container-input-placeholder-color` without breaking previous styles by setting the default value to the previous setup.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@andria-dev
Copy link
Author

I can't figure out why the travis-ci build failed from it's log, and I just filled out the CLA form.

@googlebot
Copy link

CLAs look good, thanks!

@e111077
Copy link
Member

e111077 commented Oct 29, 2018

currently working on a large refactor of paper-input. This PR may be delayed because of this

@@ -134,15 +134,15 @@ Polymer({
}

input::-webkit-input-placeholder {
color: var(--paper-input-container-color, var(--secondary-text-color));
color: var(--paper-input-container-input-placeholder-color, var(--paper-input-container-color, var(--secondary-text-color)));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add to documentation at the top

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@e111077 @ChrisBrownie55 Can this be made in a CSS mixin? I really need to be able to modify more than color ..

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@acory The @apply rule has been abandoned according to https://chromium.googlesource.com/chromium/src/+/5874fca7324e4523a4bdecc8999bdadfdb6c4eff

Therefore, it could be possible to add that in but it would also make sense to leave this in as well. That way both would still be supported.

However, I would suggest not using the @apply rule at all seeing as it is only supported for backward compatibility purposes and the Shadow Parts specification is currently the future.

https://github.com/webcomponents/shadycss

@andria-dev
Copy link
Author

Any news on whether or not this is going to be merged anytime soon? @e111077

@e111077
Copy link
Member

e111077 commented Feb 5, 2019

Still not yet, unfortunately. It might be best to fork this repo for now

@e111077 e111077 added the v4 label Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Label and placeholder share colors
4 participants