Avoid to create a new array each selection #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgecasar
commented
Apr 26, 2017
test/attr-for-selected.html
Outdated
| @@ -204,7 +204,7 @@ | |||
| assert.equal(selector.selectedItem, undefined); | |||
| selector.multi = true; | |||
| selector.selectedValues = ['non-existing-value']; | |||
| assert.deepEqual(selector.selectedItems, [undefined]); | |||
| assert.deepEqual(selector.selectedItems, []); | |||
There was a problem hiding this comment.
If you select a non existing value the selectedItems must be an empty array
jorgecasar
force-pushed
the
fix/152-selectedItems-avoid-new-array
branch
2 times, most recently
from
f90849f
to
d29ebb7
Compare
abdonrd
suggested changes
Apr 29, 2017
iron-multi-selectable.html
Outdated
| if (this.multi) { | ||
| this._setSelectedItems(s); | ||
| if (isSelected) { | ||
| this.splice('selectedItems', this.selectedItems.length, 0, item); |
There was a problem hiding this comment.
Why not simply this.push('selectedItems', item);?
iron-multi-selectable.html
Outdated
| } else { | ||
| this._setSelectedItems([s]); | ||
| this._setSelectedItem(s); | ||
| this._setSelectedItems(isSelected?[item]:[]); |
There was a problem hiding this comment.
Spaces: this._setSelectedItems(isSelected ? [item] : []);
iron-multi-selectable.html
Outdated
| this._setSelectedItems([s]); | ||
| this._setSelectedItem(s); | ||
| this._setSelectedItems(isSelected?[item]:[]); | ||
| this._setSelectedItem(isSelected?item:undefined); |
There was a problem hiding this comment.
Spaces: this._setSelectedItem(isSelected ? item : undefined);
iron-selectable.html
Outdated
| _selectionChange: function() { | ||
| this._setSelectedItem(this._selection.get()); | ||
| _selectionChange: function(isSelected, item) { | ||
| this._setSelectedItem(isSelected?item:undefined); |
There was a problem hiding this comment.
Spaces: this._setSelectedItem(isSelected ? item : undefined);
jorgecasar
force-pushed
the
fix/152-selectedItems-avoid-new-array
branch
from
d29ebb7
to
1750695
Compare
jorgecasar
force-pushed
the
fix/152-selectedItems-avoid-new-array
branch
from
7aee6b4
to
1750695
Compare
jorgecasar
force-pushed
the
fix/152-selectedItems-avoid-new-array
branch
from
1750695
to
d4d03e9
Compare
Signed-off-by: Jorge del Casar <jorge.casar@gmail.com>
jorgecasar
force-pushed
the
fix/152-selectedItems-avoid-new-array
branch
from
d4d03e9
to
f10c99c
Compare
|
Friendly ping to @bicknellr (code owner). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve #152
Signed-off-by: Jorge del Casar jorge.casar@gmail.com